IndexedDB: Add IndexedDB implementation of LinkedChunk-related functions in EventCacheStore#5406
Merged
Hywan merged 4 commits intomatrix-org:mainfrom Jul 15, 2025
Conversation
…previous_chunk Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…_all_linked_chunks Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…all_chunks_metadata Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5406 +/- ##
==========================================
- Coverage 88.81% 88.81% -0.01%
==========================================
Files 334 334
Lines 91256 91256
Branches 91256 91256
==========================================
- Hits 81051 81048 -3
- Misses 6391 6394 +3
Partials 3814 3814 ☔ View full report in Codecov by Sentry. |
Hywan
requested changes
Jul 15, 2025
Member
Hywan
left a comment
Hywan
left a comment
There was a problem hiding this comment.
Excellent! I left a feedback regarding a query made in a loop. Otherwise, it's good! Thanks.
…easy performance tracking Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Hywan
approved these changes
Jul 15, 2025
1 task
This was referenced Aug 6, 2025
1 task
This was referenced Aug 25, 2025
This was referenced Sep 16, 2025
mgoldenberg
deleted the
indexeddb-event-cache-store-linked-chunk-fns
branch
1 task
Merged
1 task
This was referenced Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This pull request is part of a series of pull requests to add a full IndexedDB implementation of the
EventCacheStore(see #4617, #4996, #5090, #5138, #5226, #5274, #5343, #5384). This particular pull request focuses on providing implementations for the remainingLinkedChunk-related functions inEventCacheStore.Changes
The changes include implementations of the following functions, as well as tests for each of them.
EventCacheStore::load_all_chunks_metadataEventCacheStore::load_previous_chunkEventCacheStore::clear_all_linked_chunksThere are also two additions to
IndexeddbEventCacheStoreTransactionwhich support the implementation of theEventCacheStore::load_all_chunks_metadata.get_events_count_by_positionget_events_count_by_chunkFuture Work
EventCacheStorefunctions without relying onMemoryStoreSigned-off-by: Michael Goldenberg m@mgoldenberg.net